test(lib-storage): speed up lib-storage e2e tests by reducing permutations#8028
Merged
Conversation
kuhe
commented
May 16, 2026
| ChecksumAlgorithm.SHA256, | ||
| ChecksumAlgorithm.CRC32, | ||
| ChecksumAlgorithm.CRC32C, | ||
| ])("ChecksumAlgorithm: %s", (ChecksumAlgorithm) => { |
Contributor
Author
There was a problem hiding this comment.
this multiplied the 3 checksum settings by the 5 checksum options, 15x whatever the test content was.
Contributor
Author
There was a problem hiding this comment.
for some reason this is taking almost 20 min on my computer, but all of e2e only takes 8min on remote builds
trivikr
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
Reduces the number of permutations in the lib-storage e2e test to allow it to complete faster.
Testing
modified e2e test
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.