fix(client-sts): update imports to new module locations#8025
Merged
Conversation
18008cd to
7a7b15d
Compare
# Conflicts: # private/aws-client-api-test/package.json # private/aws-client-retry-test/package.json # yarn.lock
kuhe
commented
May 15, 2026
| // https://github.com/aws/aws-sdk-js-v3/blob/main/codegen/smithy-aws-typescript-codegen/src/main/resources/software/amazon/smithy/aws/typescript/codegen/sts-client-defaultStsRoleAssumers.ts | ||
| import { setCredentialFeature } from "@aws-sdk/core/client"; | ||
| import { stsRegionDefaultResolver } from "@aws-sdk/region-config-resolver"; | ||
| import { setCredentialFeature, stsRegionDefaultResolver } from "@aws-sdk/core/client"; |
Contributor
Author
There was a problem hiding this comment.
The template was already updated
Contributor
Author
There was a problem hiding this comment.
it's possible that changes to how often the Java codegen is recompiled caused the resource file which contains the import path not to be picked up.
In the future I'd like to remove the resource file and use Java string templates instead. The resource file doesn't integrate well with TS tools in its current location anyway.
trivikr
approved these changes
May 15, 2026
siddsriv
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#8027
#8004
Description
./privatefolder's non-code-generated packages.Testing
CI
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.