Conversation
1f23a0d to
f994238
Compare
siddsriv
approved these changes
Mar 23, 2026
trivikr
approved these changes
Mar 23, 2026
Closed
1 task
f994238 to
df9c1ba
Compare
Closed
4 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Prior PR about this, incomplete fix: smithy-lang/smithy-typescript#1867
reported bug: #7507
reported bug: #7859
reported bug: aws/aws-cdk-cli#954
reported bug: smithy-lang/smithy-typescript#1930
Description
When
@smithy/coreis duplicated within an application'snode_modules, the error creation mechanism in the AWS SDK JS may produce a generic error instead of the expected service synthetic/generic error (e.g.S3ServiceException) or service-modeled error (e.g.BucketAlreadyExists).There was a previous PR that attempted to fix this, but it was incomplete.
Testing
new unit tests
updated snapshots
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.