Skip to content

test(snapshot-testing): error response snapshots#7836

Merged
kuhe merged 1 commit intomainfrom
kuhe/test/error-snapshots
Mar 10, 2026
Merged

test(snapshot-testing): error response snapshots#7836
kuhe merged 1 commit intomainfrom
kuhe/test/error-snapshots

Conversation

@kuhe
Copy link
Copy Markdown
Contributor

@kuhe kuhe commented Mar 9, 2026

Issue

#7788
requires smithy-lang/smithy-typescript#1915

Description

adds error response snapshots

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kuhe kuhe force-pushed the kuhe/test/error-snapshots branch from 89a79bd to c889b7d Compare March 9, 2026 20:47
@kuhe kuhe force-pushed the kuhe/test/error-snapshots branch from c889b7d to 352ba68 Compare March 10, 2026 16:11
@kuhe kuhe marked this pull request as ready for review March 10, 2026 16:11
@kuhe kuhe requested a review from a team as a code owner March 10, 2026 16:11
@kuhe kuhe merged commit 0e58193 into main Mar 10, 2026
8 checks passed
@kuhe kuhe deleted the kuhe/test/error-snapshots branch March 10, 2026 17:39
@github-actions
Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants