Skip to content

chore(clients): strip trailing periods when the last character is non-alphanumeric#7821

Merged
trivikr merged 2 commits intomainfrom
omit-confusing-punctuation
Mar 5, 2026
Merged

chore(clients): strip trailing periods when the last character is non-alphanumeric#7821
trivikr merged 2 commits intomainfrom
omit-confusing-punctuation

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Mar 5, 2026

Issue

Codegen for smithy-lang/smithy-typescript#1909

Description

Strips trailing periods when the last character is non-alphanumeric

Testing

CI

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 5, 2026 00:01
@trivikr trivikr changed the title chore(clients): omit added punctuation from deprecation messages chore(clients): strip trailing periods when the last character is non-alphanumeric Mar 5, 2026
@trivikr trivikr merged commit 6b5b50b into main Mar 5, 2026
7 checks passed
@trivikr trivikr deleted the omit-confusing-punctuation branch March 6, 2026 06:15
@github-actions
Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants