Skip to content

chore(scripts): use $npm_package_name in build:include:deps script#7782

Merged
smilkuri merged 2 commits intomainfrom
fix/copy-to-clients
Feb 24, 2026
Merged

chore(scripts): use $npm_package_name in build:include:deps script#7782
smilkuri merged 2 commits intomainfrom
fix/copy-to-clients

Conversation

@smilkuri
Copy link
Copy Markdown
Contributor

@smilkuri smilkuri commented Feb 24, 2026

Description

  • The build:include:deps script was being generated with hardcoded package names (e.g. @aws-sdk/weather-legacy-auth) instead of using the $npm_package_name, causing unnecessary diffs in pacakge.json when running generate-clients.
  • build script was incorrectly placed inside the Object type check, but build script values are strings and not objects, so that script was never executed. Modified it to place it inside the scripts object check.

Testing

CI

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner February 24, 2026 21:23
@smilkuri smilkuri force-pushed the fix/copy-to-clients branch from f62191e to f77586d Compare February 24, 2026 22:02
@smilkuri smilkuri merged commit 6e32439 into main Feb 24, 2026
7 checks passed
This was referenced Feb 27, 2026
@github-actions
Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants