Conversation
56bab77 to
0d08d14
Compare
| run: | | ||
| cd codegen/new-client-test-codegen/build/smithyprojections/new-client-test-codegen/source/typescript-client-codegen | ||
| node ../../../../../../../scripts/runtime-dependency-version-check/runtime-dep-version-check.js | ||
| node ../../../../../../../scripts/runtime-dependency-version-check/check-dependencies.js |
There was a problem hiding this comment.
why CD in if you're going to execute things outside the folder?
There was a problem hiding this comment.
are these the only validations run on generated clients?
this should be generated to the clients folder, a local commit made (for commit hooks), and then running integration tests (no e2e)
There was a problem hiding this comment.
Just realised the validation scripts use dirname to find the repo root, not process.cwd(). So cd isn't required. But, this script only scan packages, packages-internal, and private folders, so they won't validate the generated client in codegen/.../build/ anyway. Per the other comment, will generate this to clients/ folder and let the commit hooks run all validations instead.
There was a problem hiding this comment.
generate into the /private folder
260dcd1 to
966e7eb
Compare
966e7eb to
15fbb1a
Compare
196b9c4 to
ec64691
Compare
ec64691 to
2edb543
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Internal JS-6480
Description
Adds
new-client-test-codegentest model with Weather service and test the generation of client inpr-buildworkflow.Testing
CI
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.