fix(toolkit-lib): dependency constraints are too strict#514
Merged
aws-cdk-automation merged 1 commit intomainfrom May 20, 2025
Merged
fix(toolkit-lib): dependency constraints are too strict#514aws-cdk-automation merged 1 commit intomainfrom
aws-cdk-automation merged 1 commit intomainfrom
Conversation
Due to a bug, we set constraints for dependency for other monorepo packages to "any future minor version" (i.e. `^1.2.3`) forcing consumers to always use latest packages with the toolkit-lib. What we wanted to do is constrain the use to "any minor version", including already published ones, i.e. `^1`.
1065ebe to
8ba3eee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 78.97% 78.99% +0.01%
==========================================
Files 46 46
Lines 6998 6998
Branches 778 781 +3
==========================================
+ Hits 5527 5528 +1
+ Misses 1452 1449 -3
- Partials 19 21 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug, we set constraints for dependency for other monorepo packages to "any future minor version" (i.e.
^1.2.3) forcing consumers to always use latest packages with the toolkit-lib.What we wanted to do is constrain the use to "any minor version", including already published ones, i.e.
^1.This change needed an upgrade of our projen Monorepo project type, which is also part of this PR. The API changed slightly here, hence the update of other values.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license