feat(toolkit-lib): make the plugin host configurable#375
Merged
aws-cdk-automation merged 1 commit intomainfrom Apr 17, 2025
Merged
feat(toolkit-lib): make the plugin host configurable#375aws-cdk-automation merged 1 commit intomainfrom
aws-cdk-automation merged 1 commit intomainfrom
Conversation
7dab251 to
e42261f
Compare
e42261f to
8bda1f1
Compare
606979c to
eb74efe
Compare
362c548 to
3334d21
Compare
eb74efe to
441970a
Compare
441970a to
de3af2e
Compare
3334d21 to
afcc409
Compare
afcc409 to
1c396e5
Compare
1c396e5 to
3c9a248
Compare
3c9a248 to
a448495
Compare
a448495 to
ec9ce68
Compare
Design decisions: - Every toolkit gets their own plugin collection by default - Move the concept of a global singleton plugin host fully to the CLI
ec9ce68 to
fe4fc5d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 79.72% 80.73% +1.01%
==========================================
Files 65 66 +1
Lines 6885 6878 -7
Branches 787 801 +14
==========================================
+ Hits 5489 5553 +64
+ Misses 1377 1304 -73
- Partials 19 21 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the plugin host configurable for toolkit users:
Design decisions
Toolkitinstance gets a freshPluginHostby default (not a global singletonPluginHost)PluginHostgets fully moved to the CLI. That concept disappears from the toolkit and the helpers, and all functions that used to implicitly assume a global plugin host now get an explicit parameter, that defaults to a fresh plugin host if not supplied.These choices lead to a lot of downstream test changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license