Skip to content

feat(integ-runner): toolkit-lib-engine is now the only engine (removes old cli-wrapper engine)#1108

Merged
aws-cdk-automation merged 4 commits intomainfrom
mrgrain/refactor/integ-runner/remove-deprecated-cli-engine
Feb 3, 2026
Merged

feat(integ-runner): toolkit-lib-engine is now the only engine (removes old cli-wrapper engine)#1108
aws-cdk-automation merged 4 commits intomainfrom
mrgrain/refactor/integ-runner/remove-deprecated-cli-engine

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 3, 2026

This PR completes the planned deprecation of the cli-wrapper engine by removing it entirely and deleting the @aws-cdk/cdk-cli-wrapper package.

The cli-wrapper engine was deprecated in favor of the toolkit-lib engine, which uses the programmatic @aws-cdk/toolkit-lib library instead of spawning CLI processes. The deprecation notice indicated removal was scheduled for January 2026.

Changes

The toolkit-lib engine is now the only supported engine for running integration tests. The @aws-cdk/cdk-cli-wrapper package has been deleted as it is no longer needed.

To ensure backward compatibility for users who may still have --unstable=deprecated-cli-engine or --unstable=toolkit-lib-engine in their scripts, a new unstable-features.ts module gracefully handles these removed flags by emitting warnings instead of failing.

The ICdk interface and related types have been moved from @aws-cdk/cdk-cli-wrapper to @aws-cdk/integ-runner/lib/engines/cdk-interface.ts since they are still needed by the toolkit-lib engine implementation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

BREAKING CHANGE: The `--unstable=deprecated-cli-engine` option has been removed. The toolkit-lib engine is now the only supported engine for running integration tests.

The `@aws-cdk/cdk-cli-wrapper` package has been deleted as it is no longer needed. Users who were using the deprecated cli-wrapper engine will automatically use the toolkit-lib engine instead.

The `--unstable=toolkit-lib-engine` flag is also no longer needed and will emit a warning if used.
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.64%. Comparing base (c13141e) to head (2e395de).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   87.70%   87.64%   -0.06%     
==========================================
  Files          72       72              
  Lines       10121    10121              
  Branches     1337     1334       -3     
==========================================
- Hits         8877     8871       -6     
- Misses       1219     1225       +6     
  Partials       25       25              
Flag Coverage Δ
suite.unit 87.64% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain changed the title refactor(integ-runner)!: remove deprecated cli-wrapper engine feat(integ-runner): toolkit-lib-engine is now the only engine (removes old cli-wrapper engine) Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Total lines changed 2226 is greater than 1000. Please consider breaking this PR down.

@mrgrain mrgrain force-pushed the mrgrain/refactor/integ-runner/remove-deprecated-cli-engine branch from 607886b to c91da48 Compare February 3, 2026 12:29
…ing directories

- Replace strict equality check with `expect.arrayContaining()` to allow for variable directory existence
- Add explanatory comment about git not tracking empty directories
- Remove assertions for `cdk-integ.out.*` directory removal since it only occurs when the directory exists on disk
- Ensure test remains stable regardless of whether git-tracked directories are present in the test environment
@mrgrain mrgrain force-pushed the mrgrain/refactor/integ-runner/remove-deprecated-cli-engine branch from b9fe236 to 2e395de Compare February 3, 2026 12:59
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 6386a54 Feb 3, 2026
30 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/integ-runner/remove-deprecated-cli-engine branch February 3, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants