chore(spec): current cfnspec contains breaking changes we are not ready to merge yet#33481
chore(spec): current cfnspec contains breaking changes we are not ready to merge yet#33481mergify[bot] merged 3 commits intomainfrom
Conversation
| "@aws-cdk/aws-service-spec": "0.1.51", | ||
| "@aws-cdk/service-spec-importers": "0.0.64", | ||
| "@aws-cdk/service-spec-types": "0.0.117" |
There was a problem hiding this comment.
Just to guarantee the expected version and that there are no install time surprises. We remove this when we are ready to accept a new spec.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
See tag 2.178.2: aws-cdk/tools/@aws-cdk/spec2cdk/package.json Lines 35 to 37 in 89c49cc |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33481 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 238 238
Lines 14271 14271
Branches 2492 2492
=======================================
Hits 11560 11560
Misses 2425 2425
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
We need the latest spec version of this specific resource because this PR already depends on it, as it makes use of the new containerFormat property.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Restting to the versions used in 2.178.2 (see comment below).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license