Skip to content

fix(aws-cdk-lib): error annotations now have error codes#37270

Merged
mergify[bot] merged 4 commits intomainfrom
huijbers/validation-errors
Mar 18, 2026
Merged

fix(aws-cdk-lib): error annotations now have error codes#37270
mergify[bot] merged 4 commits intomainfrom
huijbers/validation-errors

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Mar 17, 2026

These are not intended to be suppressed, so that is not a feature. But they can be tracked in order to find errors that users are running into a lot.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(aws-cdk-lib): error annotations now have error codes
91c602c 
These are not intended to be suppressed, so that is not a feature. But
they can be tracked in order to find errors that users are running into
a lot.
@rix0rrr rix0rrr requested a review from a team as a code owner March 17, 2026 16:08
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 17, 2026
@github-actions github-actions Bot added the p2 label Mar 17, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2026 16:08
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Mar 17, 2026
@pahud pahud mentioned this pull request Mar 17, 2026
Open
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 17, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 18, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 18, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-03-18 08:47 UTC · Rule: default-squash
  • ✅ Checks started · in-place · dashboard
  • 🟠 Running checks
  • ⏳ Merge · ETA: 2026-03-18 09:17 UTC 🚀
Required conditions to merge
Required conditions to stay in the queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [📌 queue requirement]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue default-squash]:
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #approved-reviews-by>=1
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -approved-reviews-by~=author
      • -closed
      • -label~=(blocked|do-not-merge|no-squash|priority-pr)
      • -merged
      • -title~=(WIP|wip)
      • base!=release
      • check-success=build
      • check-success=validate-pr
      • any of:
        • -label~=pr/needs-integration-tests-deployment
        • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)
      • any of [🛡 GitHub branch protection]:
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of [🛡 GitHub branch protection]:
        • check-success = build
        • check-neutral = build
        • check-skipped = build
    • all of [📌 queue conditions of queue default-merge]:
      • label~=no-squash
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #approved-reviews-by>=1
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -approved-reviews-by~=author
      • -closed
      • -label~=(blocked|do-not-merge)
      • -merged
      • -title~=(WIP|wip)
      • check-success=build
      • check-success=validate-pr
      • any of:
        • -label~=pr/needs-integration-tests-deployment
        • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)
      • any of [🛡 GitHub branch protection]:
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of [🛡 GitHub branch protection]:
        • check-success = build
        • check-neutral = build
        • check-skipped = build
    • all of [📌 queue conditions of queue priority-squash]:
      • label~=priority-pr
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #approved-reviews-by>=1
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -approved-reviews-by~=author
      • -closed
      • -label~=(blocked|do-not-merge|no-squash)
      • -merged
      • -title~=(WIP|wip)
      • base!=release
      • check-success=build
      • check-success=validate-pr
      • any of:
        • -label~=pr/needs-integration-tests-deployment
        • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)
      • any of [🛡 GitHub branch protection]:
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of [🛡 GitHub branch protection]:
        • check-success = build
        • check-neutral = build
        • check-skipped = build

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 18, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 0b9629e into main Mar 18, 2026
18 of 19 checks passed
@mergify mergify Bot deleted the huijbers/validation-errors branch March 18, 2026 09:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 18, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rix0rrr @otaviomacedo @aws-cdk-automation