Skip to content

feat(mixins-preview): generate EventBridge pattern for all events#37081

Merged
mergify[bot] merged 2 commits intomainfrom
eventbridge-codgen-pr
Mar 10, 2026
Merged

feat(mixins-preview): generate EventBridge pattern for all events#37081
mergify[bot] merged 2 commits intomainfrom
eventbridge-codgen-pr

Conversation

@gasolima
Copy link
Copy Markdown
Contributor

@gasolima gasolima commented Feb 25, 2026

Issue # (if applicable)

N/A

Reason for this change

Currently, EventBridge event code generation only covers events that have a matching resource. However, many EventBridge schemas represent events that are not associated with a specific resource, meaning no generated helpers exist for them.

Description of changes

This PR introduces the generation of base event classes and methods that can be used without resource-based auto-filling.

These classes will be generated for:

  • Events that have a matching resource, and
  • Events that do not have a matching resource.

In the case where an event has no matching resource, these generic classes (without auto-filled resource fields) will be the only generated helpers available.

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 25, 2026 09:40
@github-actions github-actions Bot added the p2 label Feb 25, 2026
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Feb 25, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@gasolima gasolima force-pushed the eventbridge-codgen-pr branch 2 times, most recently from e774d56 to d27c3db Compare February 25, 2026 11:05
@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Feb 25, 2026
@gasolima gasolima force-pushed the eventbridge-codgen-pr branch from d27c3db to 39612ec Compare February 25, 2026 11:56
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
@gasolima gasolima force-pushed the eventbridge-codgen-pr branch from 39612ec to 777a856 Compare March 4, 2026 14:14
@gasolima gasolima force-pushed the eventbridge-codgen-pr branch from 777a856 to 9d5a931 Compare March 4, 2026 14:18
@gasolima gasolima force-pushed the eventbridge-codgen-pr branch from 9d5a931 to fd735ca Compare March 4, 2026 15:02
@aws-cdk-automation aws-cdk-automation removed the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Mar 4, 2026
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
Comment thread packages/@aws-cdk/mixins-preview/scripts/spec2eventbridge/builder.ts Outdated
@gasolima gasolima force-pushed the eventbridge-codgen-pr branch from 13e638f to 801d71d Compare March 6, 2026 13:16
@leonmk-aws leonmk-aws changed the title feat(mixins-preview): generate EventBridge pattern for events has no matching resource feat(mixins-preview): generate EventBridge pattern for all events Mar 6, 2026
@leonmk-aws leonmk-aws added the pr-linter/exempt-readme The PR linter will not require README changes label Mar 10, 2026
@leonmk-aws leonmk-aws added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 10, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 10, 2026 08:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 10, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 10, 2026

Merge Queue Status

  • Entered queue2026-03-10 08:56 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-03-10 09:41 UTC · at 33ef6a5a2ecffe18ea00af5259c3c7a0d290c393

This pull request spent 44 minutes 52 seconds in the queue, including 44 minutes 41 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 10, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit f30e836 into main Mar 10, 2026
19 of 20 checks passed
@mergify mergify Bot deleted the eventbridge-codgen-pr branch March 10, 2026 09:41
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants