Skip to content

feat(mixins-preview): expose BucketPolicyStatementsMixin publicly#36771

Merged
mergify[bot] merged 4 commits intomainfrom
mrgrain/feat/BucketPolicyStatementsMixin
Jan 22, 2026
Merged

feat(mixins-preview): expose BucketPolicyStatementsMixin publicly#36771
mergify[bot] merged 4 commits intomainfrom
mrgrain/feat/BucketPolicyStatementsMixin

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Jan 22, 2026

Reason for this change

The BucketPolicyStatementsMixin was previously located in a private directory (lib/mixins/private/s3.ts), making it inaccessible to users of the mixins-preview package. This change makes the mixin publicly available so developers can use it to add PolicyStatements to existing BucketPolicy resources.

Description of changes

  • Moved BucketPolicyStatementsMixin from lib/mixins/private/s3.ts to lib/services/aws-s3/bucket-policy.ts
  • Renamed the class from BucketPolicyStatementsMixins to BucketPolicyStatementsMixin (singular) for consistency with other mixin naming conventions
  • Exported the mixin from lib/services/aws-s3/mixins.ts
  • Updated the import in logs-delivery.ts to use the new public location

Describe any new or updated permissions being added

None.

Description of how you validated changes

Existing tests continue to pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2026 13:53
@github-actions github-actions Bot added the p2 label Jan 22, 2026
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain force-pushed the mrgrain/feat/BucketPolicyStatementsMixin branch from bd937d8 to 299e4a9 Compare January 22, 2026 13:56
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 22, 2026
@mrgrain mrgrain force-pushed the mrgrain/feat/BucketPolicyStatementsMixin branch from 299e4a9 to fcebbc2 Compare January 22, 2026 14:23
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 22, 2026 14:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain
Copy link
Copy Markdown
Contributor Author

mrgrain commented Jan 22, 2026

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 22, 2026

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 22, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 458156d into main Jan 22, 2026
17 of 18 checks passed
@mergify mergify Bot deleted the mrgrain/feat/BucketPolicyStatementsMixin branch January 22, 2026 16:26
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 22, 2026

Merge Queue Status

✅ The pull request has been merged at 3a19013

This pull request spent 8 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants