Skip to content

feat(eks): add support overwriteServiceAccount prop in service account construct#36751

Merged
mergify[bot] merged 3 commits intomainfrom
overwrite-sa
Jan 28, 2026
Merged

feat(eks): add support overwriteServiceAccount prop in service account construct#36751
mergify[bot] merged 3 commits intomainfrom
overwrite-sa

Conversation

@aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Jan 21, 2026 •
edited
Loading

Issue # (if applicable)

Reason for this change

Add support for passing overwrite to the K8Manifest resource which doesn't fail if resource exists.
This feature is needed for migrating from v1 to v2 without temporarily losing the service account.

Description of changes

Add overwriteServiceAccount prop to ServiceAccount + AlbController in EKS v1 and v2.

Describe any new or updated permissions being added

None

Description of how you validated changes

Integ + unit test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 21, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2026 15:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results96 ran95 passed1 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-no-overly-permissive-passrole.guard❌ failure

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates96 ran94 passed2 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-role-root-principal-needs-conditions.guard❌ failure
packages/@aws-cdk/aws-eks-v2-alpha/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-role-root-principal-needs-conditions.guard❌ failure

@aemada-aws aemada-aws force-pushed the overwrite-sa branch 2 times, most recently from 5b3d341 to ec6c0c7 Compare January 21, 2026 16:02
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 21, 2026
@aemada-aws aemada-aws changed the title feat(eks): add support overwrite prop in service account feat(eks): add support overwriteServiceAccount prop in service account construct Jan 26, 2026
@alvazjor alvazjor self-assigned this Jan 27, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 844cc38

This pull request spent 58 minutes 21 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

merge conflict between base and head

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 27, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pahud pahud mentioned this pull request Jan 27, 2026
Open
@alvazjor
Copy link
Contributor

alvazjor commented Jan 28, 2026

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026

requeue

✅ This pull request will be embarked automatically

Details

The head sha of this pull request, 0bdca75, was never embarked in the merge queue.

But don't worry, Mergify will embark it automatically for you.

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026 •
edited
Loading

queue

🛑 There are no queue conditions matching

Details

There are queue conditions defined in the configuration, but none matches. The pull request has not been embarked.

Details:

  • Queue default-merge:
  • -closed
  • -merged
  • label~=no-squash
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge)
  • -title~=(WIP|wip)
  • check-success=build
  • check-success=validate-pr
  • any of:
    • -label~=pr/needs-integration-tests-deployment
    • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)
  • Queue priority-squash:
  • -closed
  • -merged
  • label~=priority-pr
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash)
  • -title~=(WIP|wip)
  • base!=release
  • check-success=build
  • check-success=validate-pr
  • any of:
    • -label~=pr/needs-integration-tests-deployment
    • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)
  • Queue default-squash:
  • -closed
  • -merged
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash|priority-pr)
  • -title~=(WIP|wip)
  • base!=release
  • check-success=build
  • check-success=validate-pr
  • any of:
    • -label~=pr/needs-integration-tests-deployment
    • check-success=Deploy integration test snapshots (requires pr/needs-integration-tests-deployment label)

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026 •
edited
Loading

Merge Queue Status

🛑 Queue command has been cancelled

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3aa38f6 into main Jan 28, 2026
20 of 23 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2026

Merge Queue Status

✅ The pull request has been merged at 0bdca75

This pull request spent 9 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify bot deleted the overwrite-sa branch January 28, 2026 16:59
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvazjor alvazjor alvazjor approved these changes

Assignees

@alvazjor alvazjor

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aemada-aws @alvazjor @aws-cdk-automation