Skip to content

feat(eks-v2-alpha): add support for bootstrapSelfManagedAddons#36740

Merged
mergify[bot] merged 4 commits intomainfrom
bootstrapSelfManagedAddons
Feb 6, 2026
Merged

feat(eks-v2-alpha): add support for bootstrapSelfManagedAddons#36740
mergify[bot] merged 4 commits intomainfrom
bootstrapSelfManagedAddons

Conversation

@aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Jan 20, 2026 •
edited
Loading

Issue # (if applicable)

Reason for this change

Adds support for bootstrapSelfManagedAddons in EKS which is present in EKS v1 but not in v2.

Description of changes

  • Added support for bootstrapSelfManagedAddons

Describe any new or updated permissions being added

None

Description of how you validated changes

Integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 20, 2026 15:45
@github-actions github-actions bot added the p2 label Jan 20, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 20, 2026
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ✅SkippedFailed
Security Guardian Results24 ran24 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates24 ran23 passed1 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk/aws-eks-v2-alpha/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-role-root-principal-needs-conditions.guard❌ failure

@pahud pahud mentioned this pull request Jan 20, 2026
Open
@aemada-aws aemada-aws force-pushed the bootstrapSelfManagedAddons branch from ae29cad to 85aa61f Compare January 20, 2026 16:38
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 20, 2026 16:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 20, 2026
@pahud pahud mentioned this pull request Jan 21, 2026
Open
@aemada-aws aemada-aws force-pushed the bootstrapSelfManagedAddons branch 2 times, most recently from 0be0e5b to 4b3940c Compare January 21, 2026 15:03
@leonmk-aws leonmk-aws self-assigned this Jan 28, 2026
leonmk-aws
leonmk-aws requested changes Jan 28, 2026
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 28, 2026
@aemada-aws aemada-aws force-pushed the bootstrapSelfManagedAddons branch from 6d2dc5d to 990d5a9 Compare January 28, 2026 21:05
@leonmk-aws leonmk-aws added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Jan 29, 2026
@leonmk-aws leonmk-aws had a problem deploying to deployment-integ-test January 29, 2026 12:51 — with GitHub Actions Failure
leonmk-aws
leonmk-aws reviewed Jan 29, 2026
View reviewed changes
@aemada-aws aemada-aws had a problem deploying to deployment-integ-test February 2, 2026 09:31 — with GitHub Actions Failure
@leonmk-aws
Copy link
Contributor

leonmk-aws commented Feb 2, 2026

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2026

refresh

✅ Pull request refreshed

@aemada-aws aemada-aws had a problem deploying to deployment-integ-test February 2, 2026 16:02 — with GitHub Actions Failure
@aemada-aws aemada-aws had a problem deploying to deployment-integ-test February 3, 2026 10:06 — with GitHub Actions Failure
@aemada-aws aemada-aws had a problem deploying to deployment-integ-test February 3, 2026 19:51 — with GitHub Actions Failure
@aemada-aws aemada-aws force-pushed the bootstrapSelfManagedAddons branch from ebbc981 to 542287b Compare February 5, 2026 16:53
@aemada-aws
Copy link
Contributor Author

aemada-aws commented Feb 5, 2026 •
edited
Loading

Integ test is failing because EKS is throttling the account due to too many requests via the custom resources.

@aemada-aws aemada-aws removed the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Feb 5, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 542287b

This pull request spent 14 hours 52 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

merge conflict between base and head

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aemada-aws aemada-aws force-pushed the bootstrapSelfManagedAddons branch from 542287b to 934d667 Compare February 6, 2026 08:09
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1ffe38d into main Feb 6, 2026
20 of 23 checks passed
@mergify mergify bot deleted the bootstrapSelfManagedAddons branch February 6, 2026 08:42
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2026

Merge Queue Status

✅ The pull request has been merged at 934d667

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leonmk-aws leonmk-aws leonmk-aws approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@leonmk-aws leonmk-aws

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aemada-aws @leonmk-aws @aws-cdk-automation