Skip to content

revert(prlint): fail prlinter on codecov failures, with exemption label#32867

Merged
iliapolo merged 1 commit intomainfrom
revert-32674-conroy/prlint-codecov
Jan 12, 2025
Merged

revert(prlint): fail prlinter on codecov failures, with exemption label#32867
iliapolo merged 1 commit intomainfrom
revert-32674-conroy/prlint-codecov

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

@iliapolo iliapolo commented Jan 12, 2025

Reverts #32674

@github-actions github-actions bot added the p2 label Jan 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2025 20:15
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 12, 2025
aws-cdk-automation
aws-cdk-automation requested changes Jan 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@iliapolo iliapolo merged commit 928d3bb into main Jan 12, 2025
@iliapolo iliapolo deleted the revert-32674-conroy/prlint-codecov branch January 12, 2025 20:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 12, 2025

The pull request linter fails with the following errors:

❌ codecov/patch job is not succeeding
❌ codecov/patch/packages/aws-cdk job is not succeeding
❌ codecov/patch/packages/aws-cdk-lib/core job is not succeeding
❌ codecov/project job is not succeeding
❌ codecov/project/packages/aws-cdk job is not succeeding
❌ codecov/project/packages/aws-cdk-lib/core job is not succeeding

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 12, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1388b7d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iliapolo @aws-cdk-automation