feat(elasticloadbalancingv2): minimum Loadbalancer Capacity Unit (LCU) reservation by badmintoncryer · Pull Request #32382 · aws/aws-cdk

badmintoncryer · 2024-12-04T12:28:39Z

Issue # (if applicable)

None

Reason for this change

ELB now supports for reserving minimum LCUs for both Application and Network load balancers.

ALB: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/capacity-unit-reservation.html
NLB: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/capacity-unit-reservation.html

Description of changes

Add minimumCapacityUnit to BaseLoadBalancerProps
Verify whether minimumCapacityUnit is a positive integer

Description of how you validated changes

Add both unit and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer · 2024-12-04T12:30:17Z

I've requested for reserved minimum LCU quotas to execute integ test.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

codecov · 2024-12-04T12:41:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (7175a04) to head (7853154).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32382   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         236      236           
  Lines       14256    14256           
  Branches     2491     2491           
=======================================
  Hits        11537    11537           
  Misses       2434     2434           
  Partials      285      285

Flag	Coverage Δ
suite.unit	`80.92% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`79.74% <ø> (ø)`
packages/aws-cdk-lib/core	`82.20% <ø> (ø)`

aws-cdk-automation · 2024-12-26T00:11:44Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

badmintoncryer · 2025-01-29T13:12:47Z

+    if (
+      minimumCapacityUnit &&
+      !Token.isUnresolved(minimumCapacityUnit) &&
+      (minimumCapacityUnit < 100 || minimumCapacityUnit > 1500)


To set invalid LCU causes deployment failure.

Failed resources: MinimumCapacityUnitAlbStack | 10:09:09 PM | CREATE_FAILED | AWS::ElasticLoadBalancingV2::LoadBalancer | LB (LB8A12904C) Resource handler returned message: "CapacityUnits value must be between 100 and 1500, inclusive for load balancers of type 'application` (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: 5d0ee330-3b5c-4100-81c2-8d41d8a78065)" (RequestToken: 5c14d4bf-6259-f3d5-e9b3-9db4449cff9d, HandlerErrorCode: InvalidRequest)

badmintoncryer · 2025-01-29T13:13:29Z

+
+    if (minimumCapacityUnit && !Token.isUnresolved(minimumCapacityUnit)) {
+      const capacityUnitPerAz = minimumCapacityUnit / (props.vpc?.availabilityZones.length ?? 1);
+      if (capacityUnitPerAz < 2750 || capacityUnitPerAz > 45000) {


To set invalid minimum capacity unit causes deployment failure.

Failed resources: MinimumCapacityUnitNlbStack | 8:09:17 PM | CREATE_FAILED | AWS::ElasticLoadBalancingV2::LoadBalancer | LB (LB8A12904C) Resource handler returned message: "For load balancer type 'network`, CapacityUnits must be distributed at each zone between 2750 and 45000. (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: fe443fa7-f642-4f38-b9ca-3d8ce50b830e)" (RequestToken: 35fe4839-faa1-b459-ebd8-8f8553ab3cce, HandlerErrorCode: InvalidRequest)

Dismissing outdated PRLinter review.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

badmintoncryer · 2025-02-10T08:34:38Z

@aaythapa Thank you for your review! I've addressed all of your comments.

mergify · 2025-02-10T21:52:38Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aaythapa · 2025-02-10T21:53:20Z

Thank you as always for contributing! Everything LGTM

mergify · 2025-02-10T21:57:27Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-10T22:04:59Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

aaythapa · 2025-02-10T22:13:04Z

@mergify requeue

mergify · 2025-02-10T22:13:10Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-02-10T22:44:26Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

aaythapa · 2025-02-10T22:45:53Z

@mergify update

mergify · 2025-02-10T22:46:27Z

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/sync-from-upstream.yml without workflows permission

aaythapa · 2025-02-10T22:51:43Z

@mergify requeue

mergify · 2025-02-10T22:51:56Z

requeue

❌ This pull request head commit has not been previously disembarked from queue.

Pull request has been modified.

mergify · 2025-02-10T23:23:37Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-02-11T00:27:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7853154
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-11T00:27:42Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-11T00:27:58Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

minimum capacity unit

7b713b8

github-actions Bot added the p2 label Dec 4, 2024

aws-cdk-automation requested a review from a team December 4, 2024 12:28

github-actions Bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Dec 4, 2024

aws-cdk-automation previously requested changes Dec 4, 2024

View reviewed changes

badmintoncryer added 3 commits December 27, 2024 09:44

add unit test

8a3c9de

Merge remote-tracking branch 'origin/main' into elb-minimum-capacity

f58dbf4

add integ test

c16000e

badmintoncryer and others added 7 commits December 31, 2024 10:08

Merge branch 'main' into elb-minimum-capacity

5d424f4

Merge branch 'main' into elb-minimum-capacity

91414cd

Merge remote-tracking branch 'origin/main' into elb-minimum-capacity

dbff0e4

update integ test

17c30e5

refactor

48372f7

update alb integ

6f58e49

update integ

42ba362

badmintoncryer commented Jan 29, 2025

View reviewed changes

github-actions Bot added 2 commits January 29, 2025 22:21

update unit test

a9cc20d

update readme

8a4eaa8

badmintoncryer marked this pull request as ready for review January 29, 2025 13:26

badmintoncryer and others added 6 commits January 30, 2025 07:23

Merge branch 'main' into elb-minimum-capacity

ce84f08

update snapshot#

c7e58d2

Merge branch 'main' into elb-minimum-capacity

508bf6b

update integ

942febf

Merge remote-tracking branch 'origin/main' into elb-minimum-capacity

971842b

update integ

6411c8f

Merge branch 'main' into elb-minimum-capacity

af81bd2

update unit test

94ba97f

aaythapa previously approved these changes Feb 10, 2025

View reviewed changes

Comment thread ...ting/framework-integ/test/aws-elasticloadbalancingv2/test/integ.nlb.minimum-capacity-unit.ts

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 10, 2025

Merge branch 'main' into elb-minimum-capacity

e7373f2

aaythapa approved these changes Feb 10, 2025

View reviewed changes

Merge branch 'main' into elb-minimum-capacity

7853154

mergify Bot merged commit 9b178c1 into aws:main Feb 11, 2025

github-actions Bot locked as resolved and limited conversation to collaborators Feb 11, 2025

badmintoncryer deleted the elb-minimum-capacity branch February 11, 2025 04:32

Conversation

badmintoncryer commented Dec 4, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

badmintoncryer commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aws-cdk-automation commented Dec 26, 2024

Uh oh!

badmintoncryer Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

badmintoncryer Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

badmintoncryer commented Feb 10, 2025

Uh oh!

Uh oh!

mergify Bot commented Feb 10, 2025

Uh oh!

aaythapa commented Feb 10, 2025

Uh oh!

mergify Bot commented Feb 10, 2025

Uh oh!

mergify Bot commented Feb 10, 2025

Uh oh!

aaythapa commented Feb 10, 2025

Uh oh!

mergify Bot commented Feb 10, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify Bot commented Feb 10, 2025

Uh oh!

aaythapa commented Feb 10, 2025

Uh oh!

mergify Bot commented Feb 10, 2025

❌ Mergify doesn't have permission to update

Uh oh!

aaythapa commented Feb 10, 2025

Uh oh!

mergify Bot commented Feb 10, 2025

❌ This pull request head commit has not been previously disembarked from queue.

Uh oh!

mergify Bot commented Feb 10, 2025

Uh oh!

aws-cdk-automation commented Feb 11, 2025

AWS CodeBuild CI Report

Uh oh!

mergify Bot commented Feb 11, 2025

Uh oh!

github-actions Bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

badmintoncryer commented Dec 4, 2024 •

edited

Loading

codecov Bot commented Dec 4, 2024 •

edited

Loading