Merged
Conversation
Applies the short-term strategy described in #31 by taking an un-modelled dependency on aws-cdk-docs and displaying an error message with instructions to install aws-cdk-docs if it cannot be resolved when cdk docs is invoked.
rix0rrr
approved these changes
Jun 5, 2018
eladb
reviewed
Jun 6, 2018
| ln -s node_modules/.bin bin | ||
|
|
||
| # Symlink the docs website to docs | ||
| ln -s node_modules/aws-cdk-docs/dist/docs docs |
eladb
reviewed
Jun 6, 2018
| let documentationIndexPath: string; | ||
| try { | ||
| // tslint:disable-next-line:no-var-require Taking an un-declared dep on aws-cdk-docs, to avoid a dependency circle | ||
| const docs = require('aws-cdk-docs'); |
Contributor
There was a problem hiding this comment.
Does that just work because we deploy them side-by-side?
eladb
referenced
this pull request
Jul 16, 2018
- Move nyc and tslint config files into cdk-build-tools. - Move ignore patterns into individual packages. - Update 'create-missing-libraries.sh' - Fix copy/paste-o in LambdaRef.export() - Move build logic into library file - Invoke build for the test target - Make all routines async - Move tree hash calculation into separate package. - Introduce out-of-process caching for hash calculation. - Get rid of console.error() - Fix pkglint test and integ checkers to actually inspect contents of test/ directory. - Explain .gitallowed pattern with comment - Fix unused and broken integ tests in IAM and KMS libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the short-term strategy described in #31 by taking an un-modelled dependency on aws-cdk-docs and displaying an error message with instructions to install aws-cdk-docs if it cannot be resolved when cdk docs is invoked.