fix(eks): partition is hardcoded in ALB controller IAM policies#27541
fix(eks): partition is hardcoded in ALB controller IAM policies#27541mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Exemption RequestThis case should be covered by existing integration tests ( |
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
sumupitchayan
left a comment
There was a problem hiding this comment.
Updated the snapshots - thanks for your contribution!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This handles the issue by rewriting the policy objects before passing them to
PolicyStatement.fromJson. Resources have the partition replaced with theAws.PARTITIONtoken and in tests we assert that the ARN is no longer hardcoded in the synthesized template.Closes #22520.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license