Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.173.3
Choose a base ref
...
head repository: aws/aws-cdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.173.4
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Dec 27, 2024

  1. fix(cli): cli still fails for some plugins returning `expiration: nul… 

    …l` (#32668)

There is one more location where we need to convert `null` into `undefined` if a plugin provider returns `expiration: null`. The SDKv3 code base also expects this value to be `undefined | Date`, just like our own code does; when the plugin returns `null` we pass the value over to the SDKv3 which then does a `getTime()` on the value, and then it crashes.

Issue this fix as a patch, so that we can unblock users of a commonly used plugin at Amazon.

This is a PR targeting `v2-release`, picking exactly one line from #32111. After merging this we can patch-release.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @rix0rrr
    rix0rrr authored Dec 27, 2024
    Configuration menu
    Copy the full SHA
    4da2f65 View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.173.4

    @kaizencc
    kaizencc committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    161e678 View commit details
    Browse the repository at this point in the history

  3. chore: update changelog

    @kaizencc
    kaizencc committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    136bbf1 View commit details
    Browse the repository at this point in the history

  4. chore(release): 2.173.4 (#32669) 

    See CHANGELOG
    @mergify
    mergify[bot] authored Dec 27, 2024
    Configuration menu
    Copy the full SHA
    1dadd61 View commit details
    Browse the repository at this point in the history
Loading