SpatialQuery take ColliderTrees using Res instead of ResMut#956
Merged
Jondolf merged 1 commit intoMar 17, 2026
Conversation
Jondolf
approved these changes
Mar 17, 2026
Jondolf
left a comment
Member
There was a problem hiding this comment.
Ah good catch, this should definitely be using Res. I'll probably do a 0.6.1 patch release with this fix over the weekend, along with any other fixes we might get by then
Jondolf
pushed a commit
that referenced
this pull request
Mar 23, 2026
…956) # Objective `SpatialQuery` has this field:: ```rust collider_trees: ResMut<'w, ColliderTrees>, ``` But it only ever uses it for `self.collider_trees.iter_trees()` - which is a non-`&mut` method. Having it take the resource as mutable (in Bevy's level - not in Rust's level) needlessly prevents Bevy from parallelizing multiple systems that use `SpatialQuery`. ## Solution Change it to be `Res`. ## Testing I ran the `cast_ray_predicate` example, which uses `SpatialQuery`, and it seems to run fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
SpatialQueryhas this field::But it only ever uses it for
self.collider_trees.iter_trees()- which is a non-&mutmethod. Having it take the resource as mutable (in Bevy's level - not in Rust's level) needlessly prevents Bevy from parallelizing multiple systems that useSpatialQuery.Solution
Change it to be
Res.Testing
I ran the
cast_ray_predicateexample, which usesSpatialQuery, and it seems to run fine.