refactor: reduce library size by using lodash specific dependencies#933
Merged
jakelacey2012 merged 2 commits intoauth0:masterfrom Aug 30, 2023
Merged
refactor: reduce library size by using lodash specific dependencies#933jakelacey2012 merged 2 commits intoauth0:masterfrom
jakelacey2012 merged 2 commits intoauth0:masterfrom
Conversation
0a73b79 to
43cbdd5
Compare
This is to reduce the size of the bundle users have to install.
43cbdd5 to
3a41e11
Compare
david-renaud-okta
approved these changes
Aug 29, 2023
This was referenced Aug 30, 2023
|
Unfortunately this is bad for security as these packages are very old and some of these packages have open CVEs which are never going to be fixed. I haven't verified if these packages in particular have open CVEs, but every package depending on As that website explains, you should be able to use the main package and import e.g. You can also use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to reduce the size of the bundle users have to install.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
In 9.0.0 we introduced a change which depended on lodash as a whole, which meant our bundle size increased. We need to ensure our bundle size is small enough so customers can depend on it at the edge for serverless functions.
References
Testing
npm testare passingChecklist