Respect --no-index with --find-links in pip sync#2692
Merged
charliermarsh merged 1 commit intomainfrom Mar 27, 2024
Merged
Conversation
1d07a45 to
a95e602
Compare
a95e602 to
5a4ce28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
pip sync, we weren't properly handling cases in which a package only existed in--find-links(e.g., the user passed--offlineor--no-index).I plan to explore removing
Finderentirely to avoid these mismatch bugs betweenpip syncand other commands, but this is fine for now.Closes #2688.
Test Plan
cargo test