Disallow pyproject.toml from pip uninstall#2663
Merged
charliermarsh merged 1 commit intomainfrom Mar 26, 2024
Merged
Conversation
pyproject.toml in pip sync and pip uninstall
Member
Author
|
I'm open to allowing it for |
zanieb
approved these changes
Mar 26, 2024
Member
zanieb
left a comment
There was a problem hiding this comment.
uninstall seems like a really weird use case..
sync seems reasonable if we performed resolution... seems better for a future interface though.
d7f8382 to
50dea9c
Compare
pyproject.toml in pip sync and pip uninstallpyproject.toml from pip uninstall
Member
Author
|
I changed it to just |
50dea9c to
d64ff33
Compare
d64ff33 to
f7319ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing
pyproject.tomlorsetup.pytopip uninstallis a bit strange, since it will often require running a resolution to resolve the dependencies (e.g., build the project), which means we also need to accept--index-urland friends.