Avoid prepare_metadata_for_build_wheel calls for Hatch packages with dynamic dependencies#2645
Merged
charliermarsh merged 1 commit intomainfrom Mar 25, 2024
Merged
Avoid prepare_metadata_for_build_wheel calls for Hatch packages with dynamic dependencies#2645charliermarsh merged 1 commit intomainfrom
prepare_metadata_for_build_wheel calls for Hatch packages with dynamic dependencies#2645charliermarsh merged 1 commit intomainfrom
Conversation
f2dce6f to
cf38a49
Compare
Member
Author
|
Just the failing test to start. |
ofek
reviewed
Mar 25, 2024
3d3cdef to
702a950
Compare
e4adeac to
108af90
Compare
zanieb
reviewed
Mar 25, 2024
zanieb
approved these changes
Mar 25, 2024
fc7efd2 to
a7f2884
Compare
a7f2884 to
915223f
Compare
prepare_metadata_for_build_wheel calls for dynamic dependenciesprepare_metadata_for_build_wheel calls for Hatch packages with dynamic dependencies
|
Installed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hatch allows for highly dynamic customization of metadata via hooks. In such cases, Hatch
can't upload the PEP 517 contract, in that the metadata Hatch would return by
prepare_metadata_for_build_wheelisn't guaranteed to match that of the built wheel.Hatch disables
prepare_metadata_for_build_wheelentirely for pip. We'll instead disableit on our end when metadata is defined as "dynamic" in the pyproject.toml, which should
allow us to leverage the hook in most cases while still avoiding incorrect metadata for
the remaining cases.
Closes: #2130.