Accept setup.py and setup.cfg files in compile#2634
Merged
charliermarsh merged 1 commit intomainfrom Mar 25, 2024
Merged
Conversation
a5fb6f4 to
c68cf55
Compare
864c6dd to
d3db335
Compare
zanieb
approved these changes
Mar 23, 2024
c68cf55 to
9da1182
Compare
f285623 to
b44d083
Compare
9da1182 to
d45f850
Compare
b44d083 to
15264fa
Compare
d45f850 to
a12ac81
Compare
15264fa to
a329b8a
Compare
zanieb
approved these changes
Mar 25, 2024
Member
zanieb
left a comment
There was a problem hiding this comment.
Should we add an example to the README alongside the other sources?
3bea576 to
4b2f249
Compare
a329b8a to
ada9cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This costs us ~nothing now that we support using PEP 517 hooks for
pyproject.toml.Test Plan
cargo test