Use dense formatting for requirement version specifiers in diagnostics#2601
Merged
Use dense formatting for requirement version specifiers in diagnostics#2601
Conversation
For consistency with the output in "no solution" errors
konstin
approved these changes
Mar 22, 2024
| warning: The package `requests` requires `idna <4, >=2.5`, but `2.4` is installed. | ||
| warning: The package `requests` requires `urllib3 <3, >=1.21.1`, but `1.20` is installed. | ||
| warning: The package `requests` requires `idna<4,>=2.5`, but `2.4` is installed. | ||
| warning: The package `requests` requires `urllib3<3,>=1.21.1`, but `1.20` is installed. |
Member
There was a problem hiding this comment.
I find this one hard to read, should split name and specifier?
Member
Author
There was a problem hiding this comment.
The reason we don't tend to split the name and specifier is that we don't use ` so it's less ambiguous as a single statement. I'm thinking we should probably remove the "`" here for consistency with our other messaging, but it's not really a priority. I just want us to have a consistent presentation.
Another option is we use colors to separate the specifier from the name i.e. bold names.
Member
There was a problem hiding this comment.
i'd love using color for this, though still a space after the name for CI reports probably
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with the output in "no solution" errors