Support uv lock on a pyproject.toml that only contains dependency-groups#19087
Merged
Support uv lock on a pyproject.toml that only contains dependency-groups#19087
uv lock on a pyproject.toml that only contains dependency-groups#19087Conversation
Contributor
Author
|
Should probably do a pass over all the uses of Workspace::discover for if they're still the right choice. Like, |
zanieb
reviewed
Apr 21, 2026
Comment on lines
-133
to
+135
| Workspace::discover(project_dir, &DiscoveryOptions::default(), workspace_cache).await?; | ||
| LockTarget::Workspace(&workspace) | ||
| VirtualProject::discover(project_dir, &DiscoveryOptions::default(), workspace_cache) |
Member
There was a problem hiding this comment.
It seems like we should restructure and rename these types at some point? A virtual project is now a valid workspace.
zanieb
approved these changes
Apr 21, 2026
charliermarsh
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These special kinds of pyproject.tomls are blessed by the standards gods. Initially we only supported it in
uv pip installbut at some pointuv syncstarted supporting it. Howeveruv lockwould still hard error which is definitely "everything is wrong".Test Plan
Included is 3 tests:
conflictscurrently doesn't work (because internally we always expect a Conflict to include a PackageName)