Avoid installing tool workspace member dependencies as editable#18891
Merged
charliermarsh merged 6 commits intomainfrom Apr 14, 2026
Merged
Avoid installing tool workspace member dependencies as editable#18891charliermarsh merged 6 commits intomainfrom
charliermarsh merged 6 commits intomainfrom
Conversation
06fbbf1 to
b1dcae5
Compare
Member
Member
Author
|
That seems like a plausible approach. It's a bit odd because we already use this pattern everywhere else, but I agree that it's a bit simpler and easier to get right. I'll rework this PR. |
Member
|
I don't have strong feelings, I just explored an alternative approach and Konsti said he preferred it. I'd be curious if he feels strongly. |
29142a9 to
9824ab3
Compare
e765124 to
af8267c
Compare
Member
Author
|
I still need to remove the post-resolution rewrite here. It's surprisingly hard. |
7d9e8da to
c0ed0c7
Compare
c0ed0c7 to
b6ca158
Compare
3e4d70d to
edd77e0
Compare
konstin
reviewed
Apr 13, 2026
edd77e0 to
4e2803e
Compare
4e2803e to
0c3d86d
Compare
Member
Author
|
Thanks for your patience! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Apr 16, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [uv](https://github.com/astral-sh/uv) | patch | `0.11.6` → `0.11.7` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (uv)</summary> ### [`v0.11.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0117) [Compare Source](astral-sh/uv@0.11.6...0.11.7) Released on 2026-04-15. ##### Python - Upgrade CPython build to [`2026041`](astral-sh/uv@20260414) including an OpenSSL security upgrade ([#​19004](astral-sh/uv#19004)) ##### Enhancements - Elevate configuration errors to `required-version` mismatches ([#​18977](astral-sh/uv#18977)) - Further improve TLS certificate validation messages ([#​18933](astral-sh/uv#18933)) - Improve `--exclude-newer` hints ([#​18952](astral-sh/uv#18952)) ##### Preview features - Fix `--script` handling in `uv audit` ([#​18970](astral-sh/uv#18970)) - Fix traversal of extras in `uv audit` ([#​18970](astral-sh/uv#18970)) ##### Bug fixes - De-quote `workspace metadata` in linehaul data ([#​18966](astral-sh/uv#18966)) - Avoid installing tool workspace member dependencies as editable ([#​18891](astral-sh/uv#18891)) - Emit JSON report for `uv sync --check` failures ([#​18976](astral-sh/uv#18976)) - Filter and warn on invalid TLS certificates ([#​18951](astral-sh/uv#18951)) - Fix equality comparisons for version specifiers with `~=` operators ([#​18960](astral-sh/uv#18960)) - Fix stale Python upgrade preview feature check in project environment construction ([#​18961](astral-sh/uv#18961)) - Improve Windows path normalization ([#​18945](astral-sh/uv#18945)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now, if you use
uv tool install, we install the tool itself as non-editable, but if the tool is part of a workspace, then any workspace dependencies are (accidentally) installed as editable. This PR modifies the behavior such that those dependencies are installed as non-editable, unless--editableis provided, in which case the tool itself and any workspace dependencies respect--editable.Similar logic applies to
--withand--with-editable. If the target is in a workspace, we propagate the no-editable and yes-editable flags (respectively) to its members.Closes #16306