Fetch uv from Astral mirror during self-update#18682
Merged
Conversation
9d38982 to
96394b6
Compare
3b4f6a0 to
239998b
Compare
96394b6 to
d8f7c8b
Compare
239998b to
8acffff
Compare
8acffff to
4ada275
Compare
d8f7c8b to
2a89699
Compare
zsol
commented
Mar 24, 2026
3b21eae to
fe00f2c
Compare
7605d0f to
bc4f5ce
Compare
bc4f5ce to
60a58f9
Compare
60a58f9 to
9f5ccbc
Compare
Gankra
approved these changes
Apr 17, 2026
Contributor
Gankra
left a comment
There was a problem hiding this comment.
This is quite spooky but you did a good job with the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #18679, at a high level this PR makes uv fetch the installer script from the Astral mirror (similarly to how we fetch the ndjson for version metadata), and then run the script directly, emulating what
axoupdaterwould do.Unfortunately after downloading the installer, we have to:
modify_pathto update the user'sPATHenv var; axoupdater previously preserved themodify_pathbehavior across version upgrades, and so we do the same - based on the install receipt (which contains the value for this flag).uvprocess on Windows; axoupdater did this for us previously - otherwise we can't replace the binary on diskThis completes the
uv self update (uv itself)item in #18503, and also removes a large part (but not all!) of the axoupdater code from theuv self updatecodepath.Test Plan
Added tests, plus did this manually: