Make tags non-required for fetching wheel metadata#2700
Merged
charliermarsh merged 1 commit intomainfrom Mar 28, 2024
Merged
Conversation
4b74df8 to
c7fe181
Compare
c7fe181 to
0501440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This looks like a big change but it really isn't. Rather, I just split
get_or_build_wheelinto separateget_wheelandbuild_wheelmethods internally, which madeget_or_build_wheel_metadatacapable of not relying onTags, which in turn makes it easier for us to use theDistributionDatabasein various places without having it coupled to an interpreter or environment (something we already did forSourceDistributionBuilder).