auth: use the globally constructed client builder#16979
Merged
Conversation
Member
|
I think we should probably retain the settings structs even if they're redundant just for consistency with the rest of the code base. |
9545821 to
c0b1e82
Compare
a8ce140 to
181978f
Compare
zanieb
approved these changes
Dec 4, 2025
2 tasks
c0b1e82 to
b858f96
Compare
b858f96 to
b448041
Compare
5e10a51 to
4469013
Compare
b448041 to
1e6bfde
Compare
339091d to
e24aa96
Compare
e24aa96 to
ca809e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of each subcommand instantiating its own
BaseClientBuilder, let's use the globally constructed one.Test Plan
Existing tests.