Conversation
uv-git fetch
Member
|
cc @samypr100 (I figure you may have context — no pressure) |
Collaborator
|
I believe I noticed this too during testing when I had set UV_NO_GITHUB_FAST_PATH and it ended up in the now-removed fastpath regardless. Functionally they seemed somewhat the same (besides the "If-None-Match" header), not sure if it was intentional for it to happen twice. |
zanieb
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that we perform this fast-path in
crates/uv-distribution/src/source/mod.rs, I think the fast-path here is no longer used? In my testing, we only actually took this path when the fast-path already failed (and thus it would fail again, wasting time).