Set the cache-dependency-glob default to **/uv.lock#77
Merged
Conversation
The uv cache on the filesystem can be uploaded to the GitHub Actions cache, but they are distinct things. Also make it clear that the local cache path can be changed without using `enable-cache: true`
0e41a15 to
e3dd1bc
Compare
**uv.lock**/uv.lock
This mirrors the default behavior for setup-python
Adding the path separator `/` makes sure the files get found no matter where they are in the repo.
e3dd1bc to
47f1355
Compare
zanieb
reviewed
Sep 16, 2024
README.md
Outdated
|
|
||
| ### Local cache path | ||
|
|
||
| This action controls where `uv` stores its cache on the runner's filesystem. |
Member
There was a problem hiding this comment.
Suggested change
| This action controls where `uv` stores its cache on the runner's filesystem. | |
| This action controls where uv stores its cache on the runner's filesystem. |
We don't stylize the name as code :)
zanieb
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should aim for a solution with sane defaults that work as most users would expect it.
The current default leads to a cache that is never invalidated and thus never updated.
This also mirrors the default behaviors for setup-python which use
**/requirements.txt,**/Pipfile.lockor**/poetry.lock