Skip to content

fix example for multiple cache-dependency-glob without quote#67

Merged
eifinger merged 1 commit intoastral-sh:mainfrom
hori-ryota:fix-multi-cache-dependency-glob-example
Sep 12, 2024
Merged

fix example for multiple cache-dependency-glob without quote#67
eifinger merged 1 commit intoastral-sh:mainfrom
hori-ryota:fix-multi-cache-dependency-glob-example

Conversation

@hori-ryota
Copy link
Contributor

I tried multiple glob like followings and got error about missing files.

            '${{ matrix.working-directory }}/uv.lock'
            '${{ matrix.working-directory }}/pyproject.toml'
            '${{ matrix.working-directory }}/.python-version'

When removed quotations, succeeded.

@hori-ryota
Copy link
Contributor Author

There might be cases where the path contains spaces or other special characters, and the correct fix would be to handle this by enclosing the path in quotation marks. However, as a priority, I've updated the documentation to reflect the current behavior for now.

@hori-ryota hori-ryota closed this Sep 12, 2024
@hori-ryota hori-ryota reopened this Sep 12, 2024
@hori-ryota
Copy link
Contributor Author

I closed it by mistake. Sorry.

@eifinger
Copy link
Collaborator

Have you tried double quotation marks? "

@hori-ryota
Copy link
Contributor Author

@eifinger Yes, but not working

Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏
Multiline Yaml is a treat....

@eifinger eifinger merged commit 8e85449 into astral-sh:main Sep 12, 2024
@hori-ryota hori-ryota deleted the fix-multi-cache-dependency-glob-example branch September 13, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants