Skip to content

🚸 use GitHub token by default#61

Merged
eifinger merged 4 commits intoastral-sh:mainfrom
burgholzer:use-github-token-per-default
Sep 11, 2024
Merged

🚸 use GitHub token by default#61
eifinger merged 4 commits intoastral-sh:mainfrom
burgholzer:use-github-token-per-default

Conversation

@burgholzer
Copy link
Contributor

This PR adjusts the action so that it is no longer necessary to explicitly specify the GitHub token to circumvent the API rate limit.
To this end, it simply passes the repository's GitHub token (available via ${{ github.token }}) as a default for the github_token action input.

This is similar to how this is handled in, e.g., https://github.com/peter-evans/create-pull-request; specifically here.

@burgholzer burgholzer requested a review from eifinger as a code owner September 9, 2024 21:46
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you! I didn't know this was possible.

Some small requests and we can merge this.

@burgholzer burgholzer requested a review from eifinger September 10, 2024 19:49
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@eifinger eifinger enabled auto-merge (squash) September 11, 2024 08:17
@eifinger eifinger merged commit 49df72d into astral-sh:main Sep 11, 2024
@henryiii
Copy link

Nice, I suggested this on Discord a while back, happy to see it in!

@burgholzer
Copy link
Contributor Author

Nice, I suggested this on Discord a while back, happy to see it in!

That's what motivated me to look into it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants