RUF027 no longer has false negatives with string literals inside of method calls#9865
Merged
snowsignal merged 2 commits intomainfrom Feb 8, 2024
Merged
RUF027 no longer has false negatives with string literals inside of method calls#9865snowsignal merged 2 commits intomainfrom
snowsignal merged 2 commits intomainfrom
Conversation
…e of method calls
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF027 | 8 | 8 | 0 | 0 | 0 |
Member
|
The Rasa checks look like false positives (hard to avoid...), the Ibis check looks like a true positive (I think), the Pandas check looks like a false positive (maybe avoidable?), the Rotki checks look like they might be true positives. |
Member
|
Perhaps we could avoid the Pandas false positive by also ignoring calls with positional arguments that use the exact same name... |
MichaReiser
approved these changes
Feb 6, 2024
…ls that use variables which any method calls also use
Contributor
Author
|
@charliermarsh I added some logic to ignore literals with matching regular arguments in addition to keyword arguments. |
CodSpeed Performance ReportMerging #9865 will improve performances by 11.53%Comparing Summary
Benchmarks breakdown
|
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
…ethod calls (astral-sh#9865) Fixes astral-sh#9857. ## Summary Statements like `logging.info("Today it is: {day}")` will no longer be ignored by RUF027. As before, statements like `"Today it is: {day}".format(day="Tuesday")` will continue to be ignored. ## Test Plan The snapshot tests were expanded to include new cases. Additionally, the snapshot tests have been split in two to separate positive cases from negative cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9857.
Summary
Statements like
logging.info("Today it is: {day}")will no longer be ignored by RUF027. As before, statements like"Today it is: {day}".format(day="Tuesday")will continue to be ignored.Test Plan
The snapshot tests were expanded to include new cases. Additionally, the snapshot tests have been split in two to separate positive cases from negative cases.