Skip to content

Remove LibCST-based fixer for C403#9818

Merged
charliermarsh merged 1 commit intomainfrom
charlie/lcst
Feb 5, 2024
Merged

Remove LibCST-based fixer for C403#9818
charliermarsh merged 1 commit intomainfrom
charlie/lcst

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

Experimenting with rewriting one of the comprehension fixes without LibCST.

@charliermarsh
Copy link
Copy Markdown
Member Author

This actually does a better job of preserving comments.

@charliermarsh charliermarsh marked this pull request as ready for review February 5, 2024 00:43
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Feb 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error)

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh changed the title Remove one usage of LibCST Remove LibCST-based fixer for C403 Feb 5, 2024
@charliermarsh charliermarsh merged commit dd77d29 into main Feb 5, 2024
@charliermarsh charliermarsh deleted the charlie/lcst branch February 5, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant