Skip to content

Add our own ignored-names abstractions#9802

Merged
charliermarsh merged 1 commit intomainfrom
charlie/ignore-names
Feb 3, 2024
Merged

Add our own ignored-names abstractions#9802
charliermarsh merged 1 commit intomainfrom
charlie/ignore-names

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Feb 2, 2024 •
edited
Loading

Summary

These run over nearly every identifier. It's rare to override them, so when not provided, we can just use a match against the hardcoded default set.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9802 will not alter performance

Comparing charlie/ignore-names (6a239a7) with main (e0a6034)

Summary

✅ 30 untouched benchmarks

@charliermarsh charliermarsh added the performance Potential performance improvement label Feb 2, 2024
@charliermarsh charliermarsh marked this pull request as ready for review February 2, 2024 21:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

BurntSushi
BurntSushi approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I also like the encapsulation introduced here. Looks like the code is simpler to me. :)

@charliermarsh charliermarsh merged commit c53aae0 into main Feb 3, 2024
@charliermarsh charliermarsh deleted the charlie/ignore-names branch February 3, 2024 14:48
@miccal miccal mentioned this pull request Feb 6, 2024
Merged
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees

No one assigned

Labels

performance Potential performance improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliermarsh @BurntSushi