Skip to content

Slight speed-up for lowercase and uppercase identifier checks#9798

Merged
charliermarsh merged 1 commit intomainfrom
charlie/str
Feb 3, 2024
Merged

Slight speed-up for lowercase and uppercase identifier checks#9798
charliermarsh merged 1 commit intomainfrom
charlie/str

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Feb 2, 2024

It turns out that for ASCII identifiers, this is nearly 2x faster:

Parser/before     time:   [15.388 ns 15.395 ns 15.406 ns]
Parser/after      time:   [8.3786 ns 8.5821 ns 8.7715 ns]

@charliermarsh charliermarsh added the performance Potential performance improvement label Feb 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh marked this pull request as ready for review February 2, 2024 20:43
MichaReiser
MichaReiser approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you're micro micro optimising. I'm not sure if this is worth the extra complexity

@charliermarsh
Copy link
Copy Markdown
Member Author

charliermarsh commented Feb 2, 2024

The counterargument is that we run this on every single identifier declared within every single function.

BurntSushi
BurntSushi approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't mind the extra complexity so much in routines like this personally, because it's isolated and doesn't spread.

@charliermarsh
Copy link
Copy Markdown
Member Author

charliermarsh commented Feb 2, 2024

Need to add some non-ASCII tests (which we should have anyway).

@charliermarsh charliermarsh enabled auto-merge (squash) February 3, 2024 14:34
@charliermarsh charliermarsh merged commit 2352de2 into main Feb 3, 2024
@charliermarsh charliermarsh deleted the charlie/str branch February 3, 2024 14:40
@miccal miccal mentioned this pull request Feb 6, 2024
Merged
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

performance Potential performance improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charliermarsh @BurntSushi @MichaReiser