Skip to content

Invert order of checks in zero-sleep-call#9766

Merged
charliermarsh merged 1 commit intomainfrom
charlie/zero
Feb 1, 2024
Merged

Invert order of checks in zero-sleep-call#9766
charliermarsh merged 1 commit intomainfrom
charlie/zero

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Feb 1, 2024

The other conditions are cheaper and should eliminate the vast majority of these checks.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Feb 1, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) February 1, 2024 23:25
@zanieb
Copy link
Copy Markdown
Member

zanieb commented Feb 1, 2024

Could be in a perf category 🤷‍♀️

@charliermarsh charliermarsh added performance Potential performance improvement and removed internal An internal refactor or improvement labels Feb 1, 2024
@charliermarsh charliermarsh merged commit ded8c76 into main Feb 1, 2024
@charliermarsh charliermarsh deleted the charlie/zero branch February 1, 2024 23:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
warning: `RUF011` has been remapped to `B035`.
warning: `TCH006` has been remapped to `TCH010`.
ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
warning: `RUF011` has been remapped to `B035`.
warning: `TCH006` has been remapped to `TCH010`.
ruff failed
  Cause: Selection of deprecated rule `ANN102` is not allowed when preview is enabled.

@miccal miccal mentioned this pull request Feb 6, 2024
Merged
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

performance Potential performance improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliermarsh @zanieb