Skip to content

[flake8-pyi] Fix PYI047 false negatives on PEP-695 type aliases#9566

Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom
AlexWaygood:y047-695
Jan 18, 2024
Merged

[flake8-pyi] Fix PYI047 false negatives on PEP-695 type aliases#9566
charliermarsh merged 1 commit intoastral-sh:mainfrom
AlexWaygood:y047-695

Conversation

@AlexWaygood
Copy link
Copy Markdown
Member

Summary

Fixes one of the issues listed in #8771. Fairly straightforward!

Test Plan

cargo test / cargo insta review

@AlexWaygood AlexWaygood added the rule Implementing or modifying a lint rule label Jan 17, 2024
@AlexWaygood AlexWaygood mentioned this pull request Jan 17, 2024
7 tasks
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 17, 2024

CodSpeed Performance Report

Merging #9566 will degrade performances by 4.35%

Comparing AlexWaygood:y047-695 (209182b) with main (368e279)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main AlexWaygood:y047-695 Change
parser[numpy/ctypeslib.py] 12.2 ms 12.8 ms -4.35%

@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good!

@charliermarsh charliermarsh merged commit 848e473 into astral-sh:main Jan 18, 2024
@AlexWaygood AlexWaygood deleted the y047-695 branch January 18, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants