Recursively visit deferred AST nodes#9541
Merged
charliermarsh merged 1 commit intomainfrom Jan 16, 2024
Merged
Conversation
ed1d8d0 to
87e1bbb
Compare
87e1bbb to
a156cd9
Compare
a156cd9 to
ef91b4f
Compare
CodSpeed Performance ReportMerging #9541 will improve performances by 4.55%Comparing Summary
Benchmarks breakdown
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a more holistic fix for #9534 and #9159.
When we visit the AST, we track nodes that we need to visit later (deferred nodes). For example, when visiting a function, we defer the function body, since we don't want to visit the body until we've visited the rest of the statements in the containing scope.
However, deferred nodes can themselves contain deferred nodes... For example, a function body can contain a lambda (which contains a deferred body). And then there are rarer cases, like a lambda inside of a type annotation.
The aforementioned issues were fixed by reordering the deferral visits to catch common cases. But even with those fixes, we still fail on cases like:
Since we don't expect lambdas to appear inside of type definitions.
This PR modifies the
Checkerto keep visiting until all the deferred stacks are empty. We already do this for any one kind of deferred node; now, we do it for all of them at a level above.