Skip to content

Add some additional Python 3.12 typing members to deprecated-import#9445

Merged
charliermarsh merged 1 commit intomainfrom
charlie/types
Jan 9, 2024
Merged

Add some additional Python 3.12 typing members to deprecated-import#9445
charliermarsh merged 1 commit intomainfrom
charlie/types

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Closes #9443.

@charliermarsh charliermarsh changed the title Add some additional Python 3.12 typing members to deprecated-import Add some additional Python 3.12 typing members to deprecated-import Jan 9, 2024
@charliermarsh
Copy link
Copy Markdown
Member Author

@AlexWaygood - do you mind reviewing this one?

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jan 9, 2024
Comment thread crates/ruff_linter/src/rules/pyupgrade/rules/deprecated_import.rs
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Comment thread crates/ruff_linter/src/rules/pyupgrade/rules/deprecated_import.rs Outdated
@charliermarsh
Copy link
Copy Markdown
Member Author

\cc @AlexWaygood

Comment thread crates/ruff_linter/src/rules/pyupgrade/rules/deprecated_import.rs Outdated
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@charliermarsh charliermarsh merged commit ad1ca72 into main Jan 9, 2024
@charliermarsh charliermarsh deleted the charlie/types branch January 9, 2024 17:52
@charliermarsh
Copy link
Copy Markdown
Member Author

Thanks for the close read!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UP035 doesn't detect typing_extensions.override when targeting python 3.12

2 participants