Add cell indexes to all diagnostics#9387
Merged
charliermarsh merged 1 commit intomainfrom Jan 4, 2024
Merged
Conversation
ddd5d6d to
30d76f8
Compare
Contributor
|
konstin
approved these changes
Jan 4, 2024
30d76f8 to
a54a9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that any lint rules that include line locations render them as relative to the cell (and include the cell number) when inside a Jupyter notebook.
Closes #6672.
Test Plan
cargo test