Short rule messages should not end with a period#9345
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Jan 2, 2024
DimitriPapadopoulos:full_stop
Merged
Short rule messages should not end with a period#9345charliermarsh merged 1 commit intoastral-sh:mainfrom DimitriPapadopoulos:full_stop
charliermarsh merged 1 commit intoastral-sh:mainfrom
DimitriPapadopoulos:full_stop
Conversation
All other rule messages lack such a period, except for long messages made of multiple sentences.
Contributor
Member
|
Thanks! This is correct IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the period from a couple short messages, for consistency with all other short messages.
All other short rule messages lack such a period, except for long messages made of multiple sentences.
Test Plan
Tests modified accordingly.
Not sure if this would qualify as a breaking change because user-visible messages are modified.