Respect __str__ definitions from super classes#9338
Merged
charliermarsh merged 1 commit intomainfrom Dec 31, 2023
Merged
Conversation
d0d5c1f to
ef778fc
Compare
ef778fc to
dca0446
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| DJ001 | 36 | 18 | 18 | 0 | 0 |
| DJ008 | 4 | 0 | 4 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+18 -22 violations, +0 -0 fixes in 1 projects; 40 projects unchanged)
zulip/zulip (+18 -22 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview --select ALL
- analytics/models.py:42:16: DJ001 Avoid using `null=True` on string-based fields such as CharField + analytics/models.py:42:16: DJ001 Avoid using `null=True` on string-based fields such as `CharField` - corporate/models.py:27:26: DJ001 Avoid using `null=True` on string-based fields such as CharField + corporate/models.py:27:26: DJ001 Avoid using `null=True` on string-based fields such as `CharField` - corporate/models.py:421:19: DJ001 Avoid using `null=True` on string-based fields such as URLField + corporate/models.py:421:19: DJ001 Avoid using `null=True` on string-based fields such as `URLField` - zerver/models/custom_profile_fields.py:186:22: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/custom_profile_fields.py:186:22: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/messages.py:114:7: DJ008 Model does not define `__str__` method - zerver/models/messages.py:123:7: DJ008 Model does not define `__str__` method - zerver/models/messages.py:57:24: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/messages.py:57:24: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/messages.py:688:7: DJ008 Model does not define `__str__` method - zerver/models/messages.py:709:7: DJ008 Model does not define `__str__` method - zerver/models/messages.py:73:20: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/messages.py:73:20: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/prereg_users.py:73:17: DJ001 Avoid using `null=True` on string-based fields such as CharField + zerver/models/prereg_users.py:73:17: DJ001 Avoid using `null=True` on string-based fields such as `CharField` - zerver/models/push_notifications.py:32:18: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/push_notifications.py:32:18: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/realm_emoji.py:48:17: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/realm_emoji.py:48:17: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/realms.py:138:28: DJ001 Avoid using `null=True` on string-based fields such as URLField + zerver/models/realms.py:138:28: DJ001 Avoid using `null=True` on string-based fields such as `URLField` - zerver/models/realms.py:534:24: DJ001 Avoid using `null=True` on string-based fields such as URLField + zerver/models/realms.py:534:24: DJ001 Avoid using `null=True` on string-based fields such as `URLField` - zerver/models/scheduled_jobs.py:162:23: DJ001 Avoid using `null=True` on string-based fields such as TextField + zerver/models/scheduled_jobs.py:162:23: DJ001 Avoid using `null=True` on string-based fields such as `TextField` - zerver/models/scheduled_jobs.py:42:15: DJ001 Avoid using `null=True` on string-based fields such as EmailField + zerver/models/scheduled_jobs.py:42:15: DJ001 Avoid using `null=True` on string-based fields such as `EmailField` ... 11 additional changes omitted for rule DJ001
Changes by rule (2 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| DJ001 | 36 | 18 | 18 | 0 | 0 |
| DJ008 | 4 | 0 | 4 | 0 | 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9242.