[pylint] Implement self-cls-assignment (W0642)#9267
Merged
dhruvmanila merged 7 commits intoastral-sh:mainfrom Apr 15, 2024
Merged
[pylint] Implement self-cls-assignment (W0642)#9267dhruvmanila merged 7 commits intoastral-sh:mainfrom
pylint] Implement self-cls-assignment (W0642)#9267dhruvmanila merged 7 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLW0642 | 52 | 52 | 0 | 0 | 0 |
W0642/self-cls-assignmentpylint] - implement W0642/self-cls-assignment
318898e to
8fbfbf9
Compare
8fbfbf9 to
aae4512
Compare
pylint] - implement W0642/self-cls-assignmentpylint] - implement self-cls-assignment (W0642)
Member
|
The rule fits into the suspicious category. We should consider renaming the rule to |
dhruvmanila
requested changes
Apr 10, 2024
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you for the PR!
This looks like a great start. I've a few recommendations around testing and logic but otherwise looks good.
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pylint/rules/self_cls_assignment.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/pylint/self_cls_assignment.py
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/pylint/self_cls_assignment.py
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/pylint/self_cls_assignment.py
Show resolved
Hide resolved
Contributor
Author
|
Couldn't find any official Python documentation on why this is not a good thing to do in code, but I've added an example, and addressed other changes as well. 😄 |
dhruvmanila
approved these changes
Apr 15, 2024
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you! I made some additional changes which I've listed down:
- Check starred expressions (
*self = "foo") - Update example case and add "Use instead:" section
Looking at the ecosystem changes, a follow-up would probably be to allow type casting like the following:
self = cast(Fruits, self)
cls = cast(Colors, cls)pylint] - implement self-cls-assignment (W0642)pylint] Implement self-cls-assignment (W0642)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
W0642/self-cls-assignmentSee: #970
Test Plan
cargo test