Skip to content

Hide unsafe fix suggestions when explicitly disabled#9095

Merged
zanieb merged 1 commit intomainfrom
zb/unsafe-hint-hide
Dec 11, 2023
Merged

Hide unsafe fix suggestions when explicitly disabled#9095
zanieb merged 1 commit intomainfrom
zb/unsafe-hint-hide

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented Dec 11, 2023

Hides hints about unsafe fixes when they are disabled e.g. with --no-unsafe-fixes or unsafe-fixes = false. By default, unsafe fix hints are still displayed. This seems like a nice way to remove the nag for users who have chosen not to apply unsafe fixes.

Inspired by comment at #9063 (comment)

@zanieb zanieb requested a review from charliermarsh December 11, 2023 16:10
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb zanieb merged commit 8e9bf84 into main Dec 11, 2023
@zanieb zanieb deleted the zb/unsafe-hint-hide branch December 11, 2023 21:42
@zanieb zanieb added the cli Related to the command-line interface label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command-line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants